Implemented premium subscriber content #116
Conversation
bdunogier
force-pushed
the
EZP-22324-premium_content
branch
3 times, most recently
from
3a61b9a
to
b7a63a2
Compare
| Scenario: As a subscribed User, I get the full content | ||
| Given I am logged in as "john.doe" with password "publish" | ||
| When I go to "/Premium-article" | ||
| Then I am on the "premium_article" page |
There was a problem hiding this comment.
For both lines above we need the actual name from PM, however unsure what identifier should ideally be.
@ezsystems/qa-team: Anyone up for suggesting something on how to identify it?
There was a problem hiding this comment.
Then lets call it "Premium article" :-)
Actually it's straight forward and doesn't hurt.
|
What about a custom content view provider? |
|
Looks good from my side, but for BDD make sure someone from @ezsystems/qa-team has a look (ping) |
| And I see "This is the subscriber teaser" text | ||
| And I see "This article is only available to Premium subscribers" text | ||
| And I don't see "This summary will only be shown to subscribers" text | ||
| # And I see a login form |
There was a problem hiding this comment.
Missing implementation? Plans for it?
There was a problem hiding this comment.
Didn't we decide to skip the login form here to make it easier?
Great if we can make it, but nice to have
|
@bdunogier Will most likely setup a demo today for updating demo content, is this ready enough for @lserwatka to check this out on that demo setup so @rolandbenedetti can play around with this? @bdunogier You should also rebase, to make sure the image fix is part of the checkout of this branch, but as demo will be using beta1 not the fix from JV for image filters, so: git rebase a8eb4a6 |
| // { | ||
| // return true; | ||
| // } | ||
| // } |
There was a problem hiding this comment.
commented out? maybe remove or?
|
Given it will not be possible to get this to pass before new demo content and new packages are created it might make sense to do code first approach, then content -> packages -> tests + adjustments |
|
Hello guys, I am not sure totally about what’s happening there. Just keep in mind I need a little bit of time for the update. |
bdunogier
force-pushed
the
EZP-22324-premium_content
branch
from
b7a63a2
to
c157124
Compare
|
PR splitted, BDD tests moved to #120. |
bdunogier
force-pushed
the
EZP-22324-premium_content
branch
from
c157124
to
dcd65f6
Compare
|
Updated:
As far as I'm concerned (reviews aside of course), it is ready enough. It won't have any effect without applicable content. |
|
Looks ok, but wasn't this supposed to be a content/location controller override?, if it was we would not have to introduce settings to configure which section id this is, and would not have to "pass a flag saying you want to ignore the custom view provider". Reason for asking: this is not real security, no point imho in making a feature out of it on a low level with setting and stuff as long as it is not proper, it is better to just serve as an example. |
|
It's anything but proper. It is a bit cleaner than it was, but "proper" would be with semantic config and all :p As long as the value is stored in a property, it doesn't make much sense not to inject it. Storing it as a direct parameter container is very cheap, and is already done for equivalent features in the DemoBundle. Even if it was done with a Controller, you would either need to manually enable it. Do you think that it would have been easier to understand with a controller override for section X ? It is still a possibility, but it's still an extension point, just like view providers are. In that case, using a view provider to return the premium teaser view when applicable does make sense. |
bdunogier
force-pushed
the
EZP-22324-premium_content
branch
from
dcd65f6
to
5a5f2c6
Compare
|
Demo content updated with users in ezsystems/ezdemo#37. |
bdunogier
force-pushed
the
EZP-22324-premium_content
branch
2 times, most recently
from
91f00c8
to
a439dca
Compare
A custom location view provider displays a teasing template if the content is Premium (section id 7 (Premium)), and if the user doesn't have the subscriber role (id: 6) section_id and role_id are configured in default_settings.yml.
bdunogier
force-pushed
the
EZP-22324-premium_content
branch
from
a439dca
to
46293b4
Compare
Implemented premium subscriber content
Summary
Content from the
Premiumsection will only be fully visible by members of thePremium subscribersgroup. Users who don't match this requirement will be shown a teasing page, showing a specific attribute's content, as well as a piece of text explaining premium membership.Implementation
A custom location view provider displays a teasing template if the content is Premium (section id 7 (Premium)), and if the user doesn't have the subscriber role (id: 6).
Covered by behat scenarii.
Todo