Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-25091: "always available" flag is hardcoded to true when creating content #68

Merged
merged 1 commit into from
Nov 17, 2015

Conversation

dpobel
Copy link
Contributor

@dpobel dpobel commented Nov 12, 2015

JIRA: https://jira.ez.no/browse/EZP-25091

Description

This patch removes the hardcoded value for the "always available" flag in the content create struct and adds a parameter to the content create struct and the ContentService#newContentCreateStruct method so that it's possible to set a correct value.

Tests

unit test + manual test in PlatformUI

@dpobel
Copy link
Contributor Author

dpobel commented Nov 12, 2015

@mhyndle
Copy link
Contributor

mhyndle commented Nov 12, 2015

+1

@dpobel
Copy link
Contributor Author

dpobel commented Nov 13, 2015

self note: just discovered that the REST API is able to handle the boolean true value but not false while it's working fine with "false" (false as a string)...

@andrerom
Copy link
Contributor

+1

dpobel added a commit that referenced this pull request Nov 17, 2015
…able

Fix EZP-25091: "always available" flag is hardcoded to true when creating content
@dpobel dpobel merged commit ebe57b7 into master Nov 17, 2015
@dpobel dpobel deleted the ezp-25091_hardcoded_alwaysavailable branch November 17, 2015 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants