Fix EZP-21005: When changing siteaccess, the autosave's preview is not updated #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t updated This issue affects Chrome on Mac. To detect a siteaccess change, the change event is now used on the select, but in IE < 9, the change event does not bubbled, as a result, this fix also removes the usage of event delegation to not break this feature in IE.
|
+1, @yannickroger / @lserwatka ? |
|
+0, but it looks good, really. I just have no clue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue affects only Chrome on Mac, this is the results of this bug: http://code.google.com/p/chromium/issues/detail?id=36518
To detect a siteaccess change, the
changeevent is now used on the select, but in IE < 9, the change event does not bubbled, as a result, this fix also removes the usage of event delegation to not break this feature in IE.Tests
Manual tests in Chrome (Mac, Window and Linux), Firefox (Windows and Linux), IE 8 and 9