Fix EZP-24021: Link is wrong with non-main nodes using 'subtree_array' #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just a CS nitpick, shouldn't it be |
|
+1 besides above comment :) |
yannickroger
force-pushed
the
ezp-24021-subtree_array_main_nodes
branch
from
33ca406
to
dfd510a
Compare
|
CS fixed, will merge soon |
yannickroger
added a commit
that referenced
this pull request
Mar 16, 2015
…odes Fix EZP-24021: Link is wrong with non-main nodes using 'subtree_array'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link: https://jira.ez.no/browse/EZP-24021
Description
When displaying an object that has more than one position, when displaying a node that is not the main one, the link provided is not the right one . This is because the offset used to select the solr doc representing the node is wrong.
Note: The customer who reported this issue and provided this patch said it introduced some side effects. I was not able to find any. We asked for some feedback but he didn't reply yet.
Test
Manual test