-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] EZP-29937: Content type names are not translated in the Create tab of UDW #121
Conversation
It will require some backend done by @alongosz |
It seems like very complicated. Getting the preferred language, checking names in all languages, selecting the one from preferred. In the AdminUiConfig we have the object with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@dew326 I didn't want to mess up with property values as they are used in other contexts |
Exactly, and all usage of this content type name should be translated. |
@dew326 is right, we should reuse this, or add a new key to this array with translated names. |
We do not need a new key. We want to all usage of |
Sorry I didn't see this specific config before. Indeed that seems like the cleanest way. AdminUI PR will be posted in a few minutes. Change of |
For displaying the content type items' names we're using |
I think we should change this in both |
Yes, it can be closed. |
@dew326 be aware these could be combined to one to avoid loading all content types twice on every request |
@andrerom Yes, I know. We keep it in two because of the BC. |
@dew326 well we could find a way to set both js params based on same source data to avoid the extra load, or? |
@andrerom are you aware this PR is closed? |
@sunpietro Fully, just like to taunt you ;) But ok, I'll move the discussion to Slack ;) |
@andrerom probably, we have to ask backend guys as this config is set there. |
https://jira.ez.no/browse/EZP-29937