EZP-31038: As an editor, I want to perform more bulk actions on sub-items

[ITernovtsii]

Question	Answer
JIRA issue	EZP-31038
Type	Feature
Target version	master
BC breaks	no
Doc needed	no

New bulk actions implemented: "Hide Locations", "Unhide Locations", "Add Locations"

Notes:

• after this PR merged, changes in ezsystems/ezplatform-i18n : ezplatform-admin-ui-modules/sub_items.xlf required.
• During implementation, I found 2 years old bug (and this PR inherited the same). I believe it should be addressed outside of this PR. Separate Jira issue created for it EZP-31039
• require these changes: EZP-31038: add configuration for UDW for bulk add location ezplatform-admin-ui#1108

[bdunogier]

I like it, thank you for your contribution.
I wish we could refactor these operations into an extension point, but it would be a lot to ask (would it ?).

[ITernovtsii]

thanks @bdunogier ,
sorry, I'm a bit over time with this so will work on changes slower than on implementation.

At the same time, I started development using extraActions property, at some point found that it's making code a bit overcomplicated (duplicate UDW, events to track & clear selected items).
And, I didn't find any benefits from it (except that it would be a good example of extending the component).
Is this what you mean as "an extension point"?

[dew326]

Just a few small comments but overall looks good.

Thanks for your contribution.

[SylvainGuittard]

Thanks @ITernovtsiy for this great contribution!
@dew326 This PR is against master. Which version of eZ Platform do we target?

[SylvainGuittard]

@ITernovtsiy I am also curious to have some screenshots. // cc @inakijv for review

[ITernovtsii]

@SylvainGuittard it looks like this

[SylvainGuittard]

@ITernovtsiy Thanks for uploading the screenshots.
Just to confirm the behavior: if I select one visible content item and one hidden content item, the reveal button is active because of the single hidden item, right?

[ITernovtsii]

Right, if both hidden and visible items selected, both buttons become active.

[dew326]

@SylvainGuittard everything in the PR and ticket suggests it will be part of 3.0 (and as the semVer says new features in the new version, not in patches), but it's up to you if we want to make an exception for this one. I'm not against merging it to 2.5, we just need to make the config optional and add default empty value.

[bdunogier]

Is this what you mean as "an extension point"?

Well, I guess. I don't have a strong opinion about the implementation, but in that case, it would be an API / set of configuration that allows to add a button that acts on selected locations:

• in which circumstances the button is enabled
• its icon/label
• check for permissions
• the action it executes
• ...

[ITernovtsii]

@bdunogier Agree, it would be nice to extend current extraActions to work as you described. But I'm from the backend world and will not be able to design it well enough on React side.
I think you can add it to the product board, and who knows, maybe someone (or myself) will have time to implement it.
Anyway, it will be a separate PR.

[bdunogier]

But I'm from the backend world and will not be able to design it well enough on React side.

Haha, I have the same issue. In that case, even bigger kuddos to you for going into hostile unknown territory ! We, or somebody else, can take care of it.

[SylvainGuittard]

it's up to you if we want to make an exception for this one. I'm not against merging it to 2.5, we just need to make the config optional and add default empty value.

@dew326 let me check with the customer who was asking for this feature. I will let you know.

[DominikaK]

A few cosmetic changes to the labels.

[DominikaK]

+1 for strings

[dew326]

Just small code style, in general +1.

[katarzynazawada]

Just one thing, using the X button does not close the reveal modal. See, please http://g.recordit.co/JiK4dZRBCJ.gif

[inakijv]

@ITernovtsiy thank you for this contribution!
For the "Add new location" button, please add new icon.

location-add-new.svg.zip

[ITernovtsii]

icon pushed to ezsystems/ezplatform-admin-ui#1108

[ITernovtsii]

rebased to v1.5, let me know if it should be master

[dew326]

@ITernovtsiy As far as I know it was decided to merge it to the master (3.0)

[ITernovtsii]

oops, I thought it was planned to merge into 2.x too.
Rebasing back to the master

[ITernovtsii]

Thanks @katarzynazawada, good catch!

Fixed copy-pasting typo in c7fda4a

[katarzynazawada]

@ITernovtsiy , closing Reveal modal works fine now.
But Add locations button has no background after change. It should have blue (ez-color-secondary) background, like other buttons.

[lserwatka]

@katarzynazawada could you retest it?