Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31651: Injected edit form into search view #1400

Merged
merged 3 commits into from
Jun 16, 2020
Merged

EZP-31651: Injected edit form into search view #1400

merged 3 commits into from
Jun 16, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 15, 2020 •
edited

Question Answer
Tickets https://jira.ez.no/browse/EZP-31651
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou mentioned this pull request Jun 15, 2020
Merged
1 task
@michal-myszka michal-myszka requested a review from a team June 16, 2020 07:04
@ViniTou ViniTou mentioned this pull request Jun 16, 2020
Merged
webhdx
webhdx approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to be more specific on which version it was deprecated and when it's gonna be removed. I'm not sure if we keep BC policy on controllers, we might just remove SearchController altogether.

@lserwatka
Copy link
Member

You need to be more specific on which version it was deprecated and when it's gonna be removed. I'm not sure if we keep BC policy on controllers, we might just remove SearchController altogether.

@ViniTou we can remove it.

@ViniTou ViniTou force-pushed the ezp-31651-cutomizable-search branch from c708cf1 to 145215c Compare June 16, 2020 07:18
@lserwatka lserwatka merged commit 01c6f66 into master Jun 16, 2020
@lserwatka lserwatka deleted the ezp-31651-cutomizable-search branch June 16, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webhdx webhdx webhdx approved these changes

@michal-myszka michal-myszka michal-myszka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@ViniTou @lserwatka @webhdx @michal-myszka