EZP-31651: Extracted search logic from adminUI #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
requested review from
adamwojs,
michal-myszka,
mikadamczyk,
mnocon,
Nattfarinn,
webhdx and
a team
lserwatka
reviewed
Jun 15, 2020
michal-myszka
approved these changes
Jun 16, 2020
webhdx
approved these changes
Jun 16, 2020
mikadamczyk
reviewed
Jun 16, 2020
| use eZ\Publish\Core\MVC\ConfigResolverInterface; | ||
| use eZ\Publish\Core\Pagination\Pagerfanta\ContentSearchHitAdapter; | ||
| use eZ\Publish\Core\QueryType\QueryType; | ||
| use EzSystems\EzPlatformAdminUi\Form\Data\Search\SearchData; |
There was a problem hiding this comment.
maybe we want to copy SearchData, SearchType, and other similar classes to this package and deprecate original classes in Admin UI. Or lets remove them now from Admin UI
src/bundle/Resources/views/themes/standard/search/form.html.twig
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
FormFactoryinstead of custom one.Use in adminUI:
ezsystems/ezplatform-admin-ui#1400
TODO
As a followup I would like to extract whole logic from Controller into ViewBuilder / Listeners.
Checklist:
$ composer fix-cs)