Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31039: Remove unnecessary sorting params when updating Location priority #1643

Merged
merged 1 commit into from
Oct 27, 2020
Merged

EZP-31039: Remove unnecessary sorting params when updating Location priority #1643

merged 1 commit into from
Oct 27, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Oct 26, 2020 •
edited
Loading

Question Answer
Tickets https://jira.ez.no/browse/EZP-31039
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

As the title states.

Related ezplatform-rest PR: https://github.com/ezsystems/ezplatform-rest

Parent ezplatform-admin-ui-modules PR: ezsystems/ezplatform-admin-ui-modules#287

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 self-assigned this Oct 26, 2020
@barw4 barw4 requested review from dew326 and adamwojs October 26, 2020 15:08
@barw4 barw4 mentioned this pull request Oct 26, 2020
Merged
3 tasks
tomaszszopinski
tomaszszopinski approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 3.1.3 with diff & patch.

@lserwatka lserwatka merged commit 20cd5ed into 2.1 Oct 27, 2020
@lserwatka lserwatka deleted the ezp-31039-remove-hardcoded-sort-params branch October 27, 2020 14:49
@barw4
Copy link
Member Author

barw4 commented Oct 27, 2020

Merged into master: 0eceb7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@dew326 dew326 dew326 approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@barw4 barw4

Labels
Bug QA approved
Milestone
No milestone
5 participants
@barw4 @Steveb-p @dew326 @tomaszszopinski @lserwatka