Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31039: Skip requirement of sort params when updating Location via REST #57

Merged
merged 1 commit into from
Oct 27, 2020
Merged

EZP-31039: Skip requirement of sort params when updating Location via REST #57

merged 1 commit into from
Oct 27, 2020

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Oct 26, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31039
Type improvement
Target version v3.1
BC breaks no
Tests pass yes
Doc needed no

updateLocation API method doesn't require the existence of sort params in LocationUpdateStruct (it will use params already stored in the Location itself), we can remove them when parsing REST data.

Related ezplatform-admin-ui PR: ezsystems/ezplatform-admin-ui#1643

Parent ezpublish-kernel PR: ezsystems/ezpublish-kernel#3071

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 self-assigned this Oct 26, 2020
tomaszszopinski
tomaszszopinski approved these changes Oct 27, 2020
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 3.1.3 with diff & patch.

@lserwatka lserwatka merged commit 479ab9e into 1.1 Oct 27, 2020
@lserwatka lserwatka deleted the ezp-31039-allow-empty-sort-params branch October 27, 2020 14:55
@barw4
Copy link
Member Author

barw4 commented Oct 27, 2020

Merged into master: 276f371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@barw4 barw4

Labels
Improvement QA approved
Milestone
No milestone
4 participants
@barw4 @lserwatka @adamwojs @tomaszszopinski