Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-354: Used fullsized thumbnails if svg is provided #1756

Merged
merged 2 commits into from
May 21, 2021
Merged

IBX-354: Used fullsized thumbnails if svg is provided #1756

merged 2 commits into from
May 21, 2021

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented May 14, 2021 •
edited

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-354
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

ezsystems/ezplatform-graphql#101

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou mentioned this pull request May 14, 2021
Merged
@ViniTou ViniTou changed the base branch from master to 2.3 May 17, 2021 07:48
@ViniTou ViniTou changed the base branch from 2.3 to 2.2 May 17, 2021 07:49
@tomaszszopinski tomaszszopinski self-assigned this May 19, 2021
@tomaszszopinski
Copy link
Contributor

tomaszszopinski commented May 20, 2021 •
edited

Successful Travis build: https://travis-ci.com/github/ezsystems/ezplatform-page-builder/builds/226384115

tomaszszopinski
tomaszszopinski approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on Ibexa Exp 3.2.6 & 3.2.7-dev with patch & diff.

@lserwatka lserwatka merged commit c7097e0 into 2.2 May 21, 2021
@adamwojs adamwojs deleted the ibx-354-thumbnails branch May 21, 2021 09:20
@ViniTou
Copy link
Contributor Author

ViniTou commented May 25, 2021

merged up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianz5 damianz5 damianz5 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@tomaszszopinski tomaszszopinski

Labels
QA approved
Milestone
No milestone
8 participants
@ViniTou @tomaszszopinski @damianz5 @GrabowskiM @tischsoic @dew326 @lucasOsti @lserwatka