IBX-354: Used thumbnail strategy for thumbnail generation #101
Conversation
ViniTou
force-pushed
the
IBX-354-thumbnails
branch
from
2124a4c
to
acf1dc9
Compare
ViniTou
requested review from
adamwojs,
alongosz,
mikadamczyk,
Nattfarinn,
Steveb-p and
webhdx
| 'uri' => $thumbnail->resource, | ||
| 'width' => $thumbnail->width, | ||
| 'height' => $thumbnail->height, | ||
| 'mimeType' => $thumbnail->mimeType, |
There was a problem hiding this comment.
Missing alternativeText in this array might cause issues. Is this intentional?
There was a problem hiding this comment.
intentional
yes. Our thumbnail object (\eZ\Publish\API\Repository\Values\Content\Thumbnail) does not have alternative text atm, it would have to be implemented for every \eZ\Publish\SPI\Repository\Strategy\ContentThumbnail\Field\ThumbnailStrategy we have.
On the other hand, you maybe right and till it will happen maybe we should just put empty string there.
| $thumbnail = $this->thumbnailStrategy->getThumbnail( | ||
| $content->getContentType(), | ||
| $content->getFields(), | ||
| $content->getVersionInfo() | ||
| ); |
There was a problem hiding this comment.
hmmm I've got feeling that try ... catch statement should stay here (with proper error logging)
There was a problem hiding this comment.
From what I see we are not catchin it inside \eZ\Publish\Core\Repository\Mapper\ContentDomainMapper::buildContentDomainObject and we did not had problems with it till now as exceptions are catched (without login tho) inside specific strategies.
|
merged up |
https://issues.ibexa.co/browse/IBX-354
frontend part adjustments:
ezsystems/ezplatform-admin-ui#1756