IBX-497: As an Editor, I want to see redesigned tabs #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
requested review from
lucasOsti,
GrabowskiM and
dew326
and removed request for
lucasOsti
GrabowskiM
requested changes
Jun 14, 2021
| @@ -76,6 +76,7 @@ | |||
| <div class="panel panel-primary"> | |||
| <div class="panel-body"> | |||
| {# 'is_location_visible': location.invisible - param deprecated since EZP-32395 #} | |||
| asdf | |||
There was a problem hiding this comment.
There's asdf in this line.
tischsoic
force-pushed
the
IBX-497-as-editor-i-want-to-see-redesigned-tabs
branch
from
ac70d45
to
11f7677
Compare
GrabowskiM
requested changes
Jun 15, 2021
|
|
||
| doc.addEventListener('click', handleClickOutsideSecondaryMenu); | ||
| doc.querySelectorAll('.ibexa-tabs__toggler').forEach((toggler) => { | ||
| toggler.addEventListener('click', toggleContainer); |
There was a problem hiding this comment.
Suggested change
| toggler.addEventListener('click', toggleContainer); | |
| toggler.addEventListener('click', toggleContainer, false); |
| toggler.addEventListener('click', toggleContainer); | ||
| }); | ||
|
|
||
| doc.addEventListener('click', handleClickOutsidePopupMenu); |
There was a problem hiding this comment.
Suggested change
| doc.addEventListener('click', handleClickOutsidePopupMenu); | |
| doc.addEventListener('click', handleClickOutsidePopupMenu, false); |
| document.body.addEventListener('ez-content-tree-resized', adaptTabs); | ||
| window.addEventListener('resize', adaptTabs); | ||
| })(window, window.document, window.jQuery, window.Translator); | ||
| document.body.addEventListener('ez-content-tree-resized', adaptAlltabs); |
There was a problem hiding this comment.
Suggested change
| document.body.addEventListener('ez-content-tree-resized', adaptAlltabs); | |
| document.body.addEventListener('ez-content-tree-resized', adaptAlltabs, false); |
| @@ -0,0 +1,8 @@ | |||
| <ul class="ibexa-popup-menu {{ class|default('') }}"> | |||
| {% for item in items %} | |||
| {{ include('@ezdesign/ui/component/popup_menu/popup_menu_item.html.twig', { | |||
There was a problem hiding this comment.
I think it's bad indent below?
There was a problem hiding this comment.
Maybe? I don't know.
| @@ -1,24 +1,49 @@ | |||
| <div class="ez-header"> | |||
| <div class="container"> | |||
| <ul class="nav nav-tabs ez-tabs" role="tablist" id="ez-tab-list-{{ group }}"> | |||
| <div class="ibexa-tabs"> | |||
tischsoic
changed the title
tischsoic
force-pushed
the
IBX-497-as-editor-i-want-to-see-redesigned-tabs
branch
2 times, most recently
from
10a3376
to
d9509a4
Compare
tischsoic
force-pushed
the
IBX-497-as-editor-i-want-to-see-redesigned-tabs
branch
from
d9509a4
to
ab1bf94
Compare
dew326
reviewed
Jun 23, 2021
GrabowskiM
requested changes
Jun 24, 2021
| cancelAnimationFrame(frame); | ||
| } | ||
|
|
||
| frame = requestAnimationFrame(adaptTabsAndPopupMenu); |
There was a problem hiding this comment.
I wonder if frame is correct name, maybe sth like animationFrame? As frame is quite vast term
| this.itemHiddenClass = config.itemHiddenClass; | ||
| this.container = config.container; | ||
| this.getActiveItem = config.getActiveItem; | ||
|
|
| } | ||
|
|
||
| const lastItem = this.items[this.items.length - 1] | ||
| const isLastNonactiveItem = lastItem === activeItem ? i === this.items.length - 2 : i === this.items.length - 1; |
There was a problem hiding this comment.
what would you say for this.items.length - (lastItem === activeItem ? 2 : 1)?
There was a problem hiding this comment.
So, you are proposing this?
Suggested change
| const isLastNonactiveItem = lastItem === activeItem ? i === this.items.length - 2 : i === this.items.length - 1; | |
| const isLastNonactiveItem = i === this.items.length - (lastItem === activeItem ? 2 : 1); |
It is shorter, but for me my version is easier to understand.
Do you think that your version is easier to understand?
There was a problem hiding this comment.
I don't. ;) But also I don't like using comparison inside ternary operator, now you have three === in one line
…locations/tab.html.twig
dew326
approved these changes
Jun 29, 2021
lucasOsti
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
New tabs design
Checklist:
$ composer fix-cs)