IBX-2658: Introduce adaptive filters #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
force-pushed
the
IBX-2658-adaptive-filters
branch
2 times, most recently
from
e249408
to
0ce0213
Compare
tischsoic
requested review from
GrabowskiM,
lucasOsti and
dew326
and removed request for
GrabowskiM and
lucasOsti
GrabowskiM
requested changes
Apr 13, 2022
| @@ -62,7 +73,8 @@ | |||
| } | |||
|
|
|||
| const lastItem = this.items[this.items.length - 1]; | |||
| const isLastNonactiveItem = lastItem === activeItem ? i === this.items.length - 2 : i === this.items.length - 1; | |||
| const isLastNonactiveItem = | |||
| lastItem === activeItem ? i === itemsWithoutForce.length - 2 : i === itemsWithoutForce.length - 1; | |||
There was a problem hiding this comment.
personally I don't like conditional expression inside ternary operator, imo it's hard to read and understand
There was a problem hiding this comment.
Do you have a proposition on how to split it into a few lines?
There was a problem hiding this comment.
BTW This fragment was also discussed in comments here: ezsystems/ezplatform-admin-ui#1780 (comment)
| </div> | ||
| <div | ||
| class=" | ||
| ibexa-adaptive-filters__toggler-wrapper |
There was a problem hiding this comment.
not sure if it has to be multiline, imo multiline is needed only if you add conditional expressions in class
There was a problem hiding this comment.
It would be quite long when written in one line
lucasOsti
approved these changes
Apr 25, 2022
...bundle/Resources/views/themes/admin/ui/component/adaptive_filters/adaptive_filters.html.twig
Outdated
Show resolved
Hide resolved
...bundle/Resources/views/themes/admin/ui/component/adaptive_filters/adaptive_filters.html.twig
Outdated
Show resolved
Hide resolved
GrabowskiM
approved these changes
Apr 25, 2022
dew326
approved these changes
Apr 26, 2022
tischsoic
force-pushed
the
IBX-2658-adaptive-filters
branch
from
773ad95
to
57e1a4d
Compare
bogusez
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: