-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2658: Introduce adaptive filters #392
Conversation
e249408
to
0ce0213
Compare
@@ -62,7 +73,8 @@ | |||
} | |||
|
|||
const lastItem = this.items[this.items.length - 1]; | |||
const isLastNonactiveItem = lastItem === activeItem ? i === this.items.length - 2 : i === this.items.length - 1; | |||
const isLastNonactiveItem = | |||
lastItem === activeItem ? i === itemsWithoutForce.length - 2 : i === itemsWithoutForce.length - 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
personally I don't like conditional expression inside ternary operator, imo it's hard to read and understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a proposition on how to split it into a few lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW This fragment was also discussed in comments here: ezsystems/ezplatform-admin-ui#1780 (comment)
</div> | ||
<div | ||
class=" | ||
ibexa-adaptive-filters__toggler-wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it has to be multiline, imo multiline is needed only if you add conditional expressions in class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be quite long when written in one line
...bundle/Resources/views/themes/admin/ui/component/adaptive_filters/adaptive_filters.html.twig
Outdated
Show resolved
Hide resolved
...bundle/Resources/views/themes/admin/ui/component/adaptive_filters/adaptive_filters.html.twig
Outdated
Show resolved
Hide resolved
773ad95
to
57e1a4d
Compare
Related PRs: