IBX-587: There are some inconsistencies in buttons: ez-btn--primary and ez-btn--base-dark #1785
Conversation
composer.json
Outdated
| @@ -32,13 +32,13 @@ | |||
| "symfony/asset": "^5.0", | |||
| "symfony/yaml": "^5.0", | |||
| "jms/translation-bundle": "^1.5", | |||
| "ezsystems/ezplatform-kernel": "^1.3@dev", | |||
There was a problem hiding this comment.
I think those changes should be excluded from this PR.
There was a problem hiding this comment.
Yes, I have excluded them already. Your response was really fast. :)
tischsoic
force-pushed
the
IBX-587-there-are-some-inconsistencies-in-buttons
branch
from
3f4a2e3
to
c4c3e1c
Compare
tischsoic
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| &:focus { | ||
| box-shadow: inset 0 0 0 calculateRem(1px) $ibexa-color-base-dark; |
There was a problem hiding this comment.
We have to reset it, because Bootstrap has: .btn:focus{ box-shadow: none; }
|
QA approved. |
|
You can merge it up now. |
|
Merged up:
|
|
@tischsoic is it intented that the greyed out buttons now look like this?
This is something I've noticed when looking at the upcoming 3.3.6 and this is the PR that introduced it. |
|
We need to fix it tomorrow morning. |
Buttons on hover, should get darker, not lighter. Changes affect basically only search page.
Checklist:
$ composer fix-cs)