Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-737: Disabled buttons in Context Menu should be purple instead of grey #1797

Merged
merged 1 commit into from
Jul 8, 2021
Merged

IBX-737: Disabled buttons in Context Menu should be purple instead of grey #1797

merged 1 commit into from
Jul 8, 2021

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Jul 8, 2021 •
edited

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-737
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Issue: #1785 (comment)

After fix

Screenshot 2021-07-08 at 08 28 23

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@tischsoic tischsoic added the Bug label Jul 8, 2021
@tischsoic tischsoic self-assigned this Jul 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lserwatka
Copy link
Member

Love it! Let's merge it.

@piotrbisaga piotrbisaga self-assigned this Jul 8, 2021
piotrbisaga
piotrbisaga approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@piotrbisaga piotrbisaga left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved.
Checked on Ibexa Commerce 3.3.6-dev with .diff
Checked on Chrome & Firefox.

@lserwatka lserwatka merged commit f926d31 into 2.3 Jul 8, 2021
@lserwatka lserwatka deleted the IBX-737-disabled-buttons-in-context-menu-should-be-purple-instead-of-grey branch July 8, 2021 08:35
@lserwatka
Copy link
Member

You can merge it up now.

@piotrbisaga piotrbisaga removed their assignment Jul 8, 2021
@tischsoic
Copy link
Contributor Author

tischsoic commented Jul 8, 2021 •
edited

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@piotrbisaga piotrbisaga piotrbisaga approved these changes

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees

@tischsoic tischsoic

Labels
Bug QA approved
Milestone
No milestone
5 participants
@tischsoic @lserwatka @GrabowskiM @dew326 @piotrbisaga