IBX-1072: Redesign site factory #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-1072-redesign-site-factory
branch
2 times, most recently
from
ec41e74
to
8451eb1
Compare
lucasOsti
force-pushed
the
IBX-1072-redesign-site-factory
branch
from
69ea134
to
185ecf8
Compare
GrabowskiM
requested changes
Oct 1, 2021
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| &__header-label { | |||
| margin: 0; | |||
| font-size: calculateRem(16px); | |||
There was a problem hiding this comment.
Suggested change
| font-size: calculateRem(16px); | |
| font-size: $ibexa-text-font-size; |
| } | ||
| } | ||
| } | ||
|
|
||
| &--heavy.ibexa-collapse--collapsed { |
There was a problem hiding this comment.
Move it to selector above
GrabowskiM
approved these changes
Oct 5, 2021
dew326
approved these changes
Oct 7, 2021
| @@ -50,7 +50,7 @@ | |||
|
|
|||
| addItems(items, forceRecreate) { | |||
| if (this.isSingleSelect) { | |||
| this.inputField.value = items[0].id; | |||
| this.inputField.value = items[0]?.id || ''; | |||
There was a problem hiding this comment.
Suggested change
| this.inputField.value = items[0]?.id || ''; | |
| this.inputField.value = items[0]?.id ?? ''; |
?
tischsoic
requested changes
Oct 7, 2021
| @@ -1,5 +1,9 @@ | |||
| {% import '@ezdesign/ui/component/macros.html.twig' as macros %} | |||
|
|
|||
| <li class="ibexa-popup-menu__item {{ class|default('') }}"> | |||
| <button type="button" class="ibexa-popup-menu__item-content {{ content_class|default('') }}" {{ macros.attributes(action_data_attr|default({})) }}>{{ label }}</button> | |||
| {% if action_data_attr.href is defined %} | |||
There was a problem hiding this comment.
href is not a data attribute.
| line-height: calculateRem(24px); | ||
| } | ||
|
|
||
| &__bottom-info { |
There was a problem hiding this comment.
maybe just __info? as I don't see other infos
lucasOsti
force-pushed
the
IBX-1072-redesign-site-factory
branch
from
7a4d20b
to
03dc0db
Compare
tischsoic
approved these changes
Oct 7, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
approved these changes
Oct 11, 2021
dew326
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)