-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1072: Redesign site factory #1921
IBX-1072: Redesign site factory #1921
Conversation
ec41e74
to
8451eb1
Compare
69ea134
to
185ecf8
Compare
@@ -16,6 +16,7 @@ | |||
|
|||
&__header-label { | |||
margin: 0; | |||
font-size: calculateRem(16px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-size: calculateRem(16px); | |
font-size: $ibexa-text-font-size; |
} | ||
} | ||
} | ||
|
||
&--heavy.ibexa-collapse--collapsed { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move it to selector above
@@ -50,7 +50,7 @@ | |||
|
|||
addItems(items, forceRecreate) { | |||
if (this.isSingleSelect) { | |||
this.inputField.value = items[0].id; | |||
this.inputField.value = items[0]?.id || ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.inputField.value = items[0]?.id || ''; | |
this.inputField.value = items[0]?.id ?? ''; |
?
@@ -1,5 +1,9 @@ | |||
{% import '@ezdesign/ui/component/macros.html.twig' as macros %} | |||
|
|||
<li class="ibexa-popup-menu__item {{ class|default('') }}"> | |||
<button type="button" class="ibexa-popup-menu__item-content {{ content_class|default('') }}" {{ macros.attributes(action_data_attr|default({})) }}>{{ label }}</button> | |||
{% if action_data_attr.href is defined %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
href
is not a data attribute.
line-height: calculateRem(24px); | ||
} | ||
|
||
&__bottom-info { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just __info
? as I don't see other infos
7a4d20b
to
03dc0db
Compare
Kudos, SonarCloud Quality Gate passed!
|
Checklist:
$ composer fix-cs
)