Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29613: As a developer I want access ContentType on Content to avoid re-loading it #633

Merged
merged 2 commits into from
Dec 4, 2018

Commits on Dec 4, 2018

  1. EZP-29613: As a developer I want access ContentType on Content to avo…

    …id re-loading it
    
    Uses ezsystems/ezpublish-kernel#2444, and $location->getContent()
    (v2.2) in order avoid several repository loads not needed anymore.
    
    Here are some numbers for cache lookups on clean install, expect difference to be bigger when you have more data (demo or project):
    
    dashboard:
    418 / 1240 (33.71%) _(master)_
    468 / 1315 (35.59%) _(with kernel PR, only)_*
    364 / 1043 (34.9%) _(with this PR + kernel PR)_
    
    content structure:
    478 / 1401 (34.12%)  _(master)_
    450 / 1359 (33.11%) _(with kernel PR, only)_
    436 / 1327 (32.86%) _(with this PR + kernel PR)_
    
    _* So withouth this patch there is a slight regression with more cache loads with the kernel PR on dashboard.
    Probably due to kernel now always loading content types from API instead of falling back to using SPI,
    and via api language loading and mapping is needed. With this PR we get rid of the duplicated loads,
    and for other apps the extra lanfguage load and much more will go away once we have inMemory cache again (v2.4)._
    andrerom committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    d808099 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eecc3de View commit details
    Browse the repository at this point in the history