Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32214: Made purge type configuration using env vars resolvable at compile time #148

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Dec 16, 2020

Question Answer
JIRA issue EZP-32214
Type improvement
Target eZ Platform version v3.3 - please update x accordingly
BC breaks no
Doc needed no

Since we are using ENV variables to setup HTTP Cache purge driver, it's needed to resolve all envs at compile time. This is rather bad solution because ENVs are not designed to be used this way. In order to make it work we need to call Container::resolveEnvPlaceholders to get real values. Previously it was working because config/packages/overrides/*.php files were used and they resolved values themselves.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team December 16, 2020 10:36
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#goodChange

Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved.

Please remember to remove TMP changes in ezsystems/ezplatform#632 before merging.

@webhdx webhdx merged commit 4f0bc5e into master Dec 21, 2020
@webhdx webhdx deleted the http_cache_purge_drive branch December 21, 2020 18:30
Steveb-p pushed a commit that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes not fixing or changing behavior Ready for review
5 participants