Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28032: Refactored namespaces for the new package #1

Merged
merged 10 commits into from
May 16, 2019
Merged

EZP-28032: Refactored namespaces for the new package #1

merged 10 commits into from
May 16, 2019

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented May 14, 2019

Jira: https://jira.ez.no/browse/EZP-28032

Desc

ezsystems/ezpublish-kernel#2630

Code is only moved from Kernel and adjusted to new namespaces, and /bundle, /lib structure and separated /tests.

@ViniTou ViniTou mentioned this pull request May 14, 2019
Merged
4 tasks
alongosz
alongosz requested changes May 15, 2019
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep here only 1:1 move from Kernel and extract other commits to a separate PR? Maybe composer.json calls for a separate PR also so we can merge it quickly and add to packagist.

bootstrap.php Outdated Show resolved Hide resolved
@alongosz
Copy link
Member

@ViniTou you can rebase now

@ViniTou ViniTou requested a review from alongosz May 16, 2019 07:47
alongosz
alongosz requested changes May 16, 2019
View reviewed changes
phpunit.xml Outdated Show resolved Hide resolved
@ViniTou ViniTou requested a review from alongosz May 16, 2019 09:31
@alongosz alongosz changed the title EZP-28032: As a Maintainer I want REST to be moved out of ezpublish-kernel EZP-28032: Refactored namespaces for the new package May 16, 2019
@alongosz alongosz merged commit 5124ba9 into ezsystems:master May 16, 2019
@alongosz alongosz deleted the EZP-28032-rest-common branch May 16, 2019 10:32
barw4 pushed a commit that referenced this pull request Jan 12, 2022
@ViniTou
Synced ezsystems/ezplatform-rest:master with ibexa/rest:main
b67e66c 
Merge pull request #1 from ibexa/merge-master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

Assignees
No one assigned
Labels
Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ViniTou @alongosz