Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-366: Implemented DateMetadataCriterion to REST API #70

Merged
merged 2 commits into from
May 25, 2021
Merged

IBX-366: Implemented DateMetadataCriterion to REST API #70

merged 2 commits into from
May 25, 2021

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented May 20, 2021 •
edited

Question Answer
JIRA issue IBX-366
Type feature/improvement
Target version v3.3
BC breaks no
Tests pass yes
Doc needed no

Merge up from: ezsystems/ezpublish-kernel#3100

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mateuszdebinski mateuszdebinski changed the base branch from master to 1.2 May 20, 2021 09:15
@mateuszdebinski mateuszdebinski requested a review from a team May 20, 2021 12:53
kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes May 24, 2021
View reviewed changes
Copy link

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA - approved. Tested on 3.2.7 - enterprise, commerce and 3.3.3 - experience, commerce.

@adamwojs adamwojs merged commit a617dd4 into 1.2 May 25, 2021
@adamwojs adamwojs deleted the IBX-366-add-DateMetadataCriterion-to-rest-api branch May 25, 2021 06:10
@adamwojs
Copy link
Member

Could you please merge up changes @mateuszdebinski?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

Assignees
No one assigned
Labels
Bug Ready for QA
Milestone
No milestone
4 participants
@mateuszdebinski @adamwojs @alongosz @kacper-wieczorek-ibexa