Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-366: Implemented DateMetadataCriterion to REST API #3100

Merged
merged 9 commits into from
May 21, 2021
Merged

IBX-366: Implemented DateMetadataCriterion to REST API #3100

merged 9 commits into from
May 21, 2021

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented May 11, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-366
Bug/Improvement no
New feature yes
Target version 7.5
BC breaks no
Tests pass yes
Doc needed yes/no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs changed the title IBX-366 implemented DateMetadataCriterion to REST API IBX-366: Implemented DateMetadataCriterion to REST API May 12, 2021
Steveb-p
Steveb-p approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

eZ/Publish/Core/REST/Server/Input/Parser/Criterion/DateMetadata.php Outdated Show resolved Hide resolved
kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes May 20, 2021
View reviewed changes
Copy link

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qa - Approved. Tested on 2.5.18

@mateuszdebinski mateuszdebinski mentioned this pull request May 20, 2021
Merged
3 tasks
@adamwojs adamwojs merged commit 2de5aa8 into 7.5 May 21, 2021
@adamwojs adamwojs deleted the IBX-366--add-DateMetadataCriterion-to-rest-api branch May 21, 2021 11:22
blankse pushed a commit to datafactory/ezpublish-kernel that referenced this pull request Mar 2, 2023
@mateuszdebinski @blankse
IBX-366: Implemented DateMetadataCriterion to REST API (ezsystems#3100)
a71ebfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
5 participants
@mateuszdebinski @adamwojs @Steveb-p @alongosz @kacper-wieczorek-ibexa