Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31772: implement custom tag link #157

Closed
wants to merge 1 commit into from
Closed

EZP-31772: implement custom tag link #157

wants to merge 1 commit into from

Conversation

ITernovtsii
Copy link
Contributor

Question Answer
JIRA issue EZP-31772
Bug/Improvement yes
New feature no
Target version 2.1
BC breaks no
Tests pass yes
Doc needed no

Currently, there is no UI for "link" custom tag attribute, so admin needs manually type location id.
Also, after admin typed it manually, it's still hard to say what's the content selected and be sure there is no typo in id.

I would like UI to contain:

  • ability to select content
  • ability to type link value manually
  • display name of selected/typed object
    demo

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ITernovtsii ITernovtsii changed the title implement custom tag link EZP-31772: implement custom tag link Jul 23, 2020
@ITernovtsii
Copy link
Contributor Author

Could you please release this simple solution while more complex #112 is in progress?

@dew326
Copy link
Member

dew326 commented Jul 23, 2020

I worked on the frontend part (ezsystems/ezplatform-admin-ui#1213) and I assume your solution will work in a similar way. This will pass to the template just a string with ezlocation://2?

@ITernovtsii
Copy link
Contributor Author

@dew326 Yes, it's just a UI change.
I hope it can be released as a fix while you're working on a more complete solution in ezsystems/ezplatform-admin-ui#1213 and #112
It looks like you still have work to do there to cover "display name of selected/typed object".
You know, community waiting for this for about 1 year already. Some of us building in-house solutions for this (cc: @AlexKhram), and it requires updates after each release, so it would make sense to have it in core ASAP to reduce time spending on things we'll have removed at some point.
What do you think? Can this be included in the next release, or would you be able to release ezsystems/ezplatform-admin-ui#1213 instead?

@dew326
Copy link
Member

dew326 commented Jul 23, 2020

I think we don't plan to cover the case with displaying the content name as we wanted to keep it consistent with the regular link in AlloyEditor.

The question about if we can finish our solution is more for @adamwojs.

@ITernovtsii
Copy link
Contributor Author

hm, so maybe it makes sense to include content name in regular link too? It was a helpful feature in legacy.

@dew326
Copy link
Member

dew326 commented Jul 23, 2020

I think it might be a useful feature but let's do it step by step. Firstly we have to figure out if we can finish the "complex" solution.

@SerheyDolgushev
Copy link
Contributor

Meantime we are going to make a separate bundle for this PR.

@ITernovtsii
Copy link
Contributor Author

released https://packagist.org/packages/contextualcode/ezplatform-alloyeditor-custom-tag-link

@ITernovtsii
Copy link
Contributor Author

closing, as it's released as a bundle, and there is a duplicate ticket - ezsystems/ezplatform-admin-ui#1213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants