EZP-32187: Fix RichText unresponsive after cancel editing of custom tag attributes #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
approved these changes
Nov 27, 2020
GrabowskiM
approved these changes
Nov 27, 2020
lucasOsti
approved these changes
Nov 27, 2020
micszo
approved these changes
Nov 30, 2020
|
@dew326 could you merge it up? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STR:
On a clean install, edit any content with richtext field
Click "+" (Add) button on the left
Select "Facebook" tag (or any other)
Fill attributes and save
On the top bar, click "pencil" (edit) icon to edit custom tag attributes
Click "Cancel"
AR: Richtext fields editing unresponsive, error in console - "Cannot read property 'isAligned' of null"
ER: Attributes editing closed, and top bar displayed. The same as after "Save" button click.
TODO:
$ composer fix-cs).