Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30731: Pagination limits are not recognized except for user_settings_limit #41

Closed
wants to merge 1 commit into from
Closed

EZP-30731: Pagination limits are not recognized except for user_settings_limit #41

wants to merge 1 commit into from

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Jul 8, 2019 •
edited
Loading

Question Answer
Tickets EZP-30731
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

In eZ Platform v2.5.2 is not possible to configure pagination for the elements defined in https://github.com/ezsystems/ezplatform-admin-ui/blob/master/src/bundle/DependencyInjection/Configuration/Parser/Pagination.php#L40-L62: the pagination node definition has been overwritten by https://github.com/ezsystems/ezplatform-user/blob/master/src/bundle/DependencyInjection/Configuration/Parser/Pagination.php#L36-L42

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@adamwojs adamwojs added the Bug Something isn't working label Jul 8, 2019
@adamwojs adamwojs self-assigned this Jul 8, 2019
@adamwojs adamwojs requested review from ViniTou and webhdx July 8, 2019 10:09
@micszo micszo self-assigned this Jul 8, 2019
@adamwojs
Copy link
Member Author

adamwojs commented Jul 9, 2019 •
edited
Loading

Unfortunately, we need a different solution for 1.0 branch. Method getChildNodeDefinitions is available only in Symfony >= 4.1 Ref. symfony/symfony@15e05e1 Thanks for catching that @micszo.

@ViniTou ViniTou mentioned this pull request Jun 4, 2020
Merged
2 tasks
@adamwojs
Copy link
Member Author

Closing as obsolete.

@adamwojs adamwojs closed this Aug 27, 2023
@adamwojs adamwojs deleted the ezp_30731 branch August 27, 2023 13:21
@micszo micszo removed their assignment Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees

@adamwojs adamwojs

Labels
Bug Something isn't working
Milestone
No milestone
4 participants
@adamwojs @alongosz @ViniTou @micszo