Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31668: Introduced new key for user related pagination configuration #72

Merged
merged 2 commits into from Jun 15, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jun 4, 2020

Question Answer
Tickets EZP-31668
Bug fix? yes
New feature? no
BC breaks? yes
Tests pass? yes
Doc needed? yes
License GPL-2.0

This is counterproposition to #41 that fix the issue in the easiest way, as it seems those parameters are not widely used this seems to be safe change in terms of making all other pagination parameters accessible.

it is now:

ezpublish:
   system:
     default:
           pagination_user: # <-- new
               user_settings_limit: 10

instead of

ezpublish:
   system:
     default: 
           pagination: # <-- old
               user_settings_limit: 10

ezsystems/ezplatform-admin-ui#1394

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@@ -26,16 +26,11 @@
*/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also a key for pagination_user in comment above

@micszo micszo self-assigned this Jun 15, 2020
@micszo
Copy link
Member

micszo commented Jun 15, 2020

FYI, in case everyone isn't aware, if one limit is set under pagination key then it is required that all the keys are set (17).

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE 2.5.11 with branches.

@micszo micszo removed their assignment Jun 15, 2020
@lserwatka lserwatka merged commit 20503ad into 1.0 Jun 15, 2020
@lserwatka lserwatka deleted the EZP-31668-pagination-configuration branch June 15, 2020 11:20
@lserwatka
Copy link
Member

You can merge it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants