Merge pull request #288 from patrickallaert/remove-UselessOverridingM…

…ethod-warnings Changed: removed useless overriding methods
ezsystems · Apr 16, 2013 · cd2743e · cd2743e
2 parents a07fd33 + 3711261
commit cd2743e
Show file tree

Hide file tree

Showing 12 changed files with 4 additions and 112 deletions.
diff --git a/eZ/Publish/API/Repository/Tests/Stubs/Values/Content/ContentInfoStub.php b/eZ/Publish/API/Repository/Tests/Stubs/Values/Content/ContentInfoStub.php
@@ -24,11 +24,6 @@ class ContentInfoStub extends ContentInfo
      */
     protected $repository;
 
-    public function __get( $property )
-    {
-        return parent::__get( $property );
-    }
-
     /**
      * Internal helper method to modify the $mainLocationId property
      *

diff --git a/eZ/Publish/API/Repository/Values/Content/Query/Criterion/Field.php b/eZ/Publish/API/Repository/Values/Content/Query/Criterion/Field.php
@@ -20,21 +20,6 @@
  */
 class Field extends Criterion implements CriterionInterface
 {
-    /**
-     * Creates a new Field Criterion.
-     *
-     * Matches $fieldIdentifier against $value using $operator.
-     * $fieldIdentifier is same value as eZ\Publish\API\Repository\Values\Content\Field->fieldDefIdentifier
-     *
-     * @param string $fieldIdentifier The target field identifier
-     * @param string $operator The match operator
-     * @param mixed $value The value to match against
-     */
-    public function __construct( $fieldIdentifier, $operator, $value )
-    {
-        parent::__construct( $fieldIdentifier, $operator, $value );
-    }
-
     public function getSpecifications()
     {
         return array(

diff --git a/eZ/Publish/API/Repository/Values/Content/Query/Criterion/LogicalAnd.php b/eZ/Publish/API/Repository/Values/Content/Query/Criterion/LogicalAnd.php
@@ -10,19 +10,9 @@
 namespace eZ\Publish\API\Repository\Values\Content\Query\Criterion;
 
 /**
- * This class does...
+ * This criterion implements a logical AND criterion and will only match
+ * if ALL of the given criteria match
  */
 class LogicalAnd extends LogicalOperator
 {
-    /**
-     * Creates a new AND logic criterion.
-     *
-     * This criterion will only match if ALL of the given criteria match
-     *
-     * @param Criterion[] $criteria
-     */
-    public function __construct( array $criteria )
-    {
-        parent::__construct( $criteria );
-    }
 }
diff --git a/eZ/Publish/API/Repository/Values/Content/Query/Criterion/LogicalOr.php b/eZ/Publish/API/Repository/Values/Content/Query/Criterion/LogicalOr.php
@@ -10,19 +10,9 @@
 namespace eZ\Publish\API\Repository\Values\Content\Query\Criterion;
 
 /**
- * This class does...
+ * This criterion implements a logical OR criterion and will only match
+ * if AT LEAST ONE of the given criteria match
  */
 class LogicalOr extends LogicalOperator
 {
-    /**
-     * Creates a new OR logic criterion.
-     *
-     * This criterion will match if AT LEAST ONE of the given criteria match
-     *
-     * @param Criterion[] $criteria
-     */
-    public function __construct( array $criteria )
-    {
-        parent::__construct( $criteria );
-    }
 }
diff --git a/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Map/Host.php b/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Map/Host.php
@@ -15,16 +15,6 @@
 
 class Host extends Map implements Matcher
 {
-    /**
-     * Constructor.
-     *
-     * @param array $siteAccessesConfiguration SiteAccesses configuration.
-     */
-    public function __construct( array $siteAccessesConfiguration )
-    {
-        parent::__construct( $siteAccessesConfiguration );
-    }
-
     public function getName()
     {
         return 'host:map';

diff --git a/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Map/Port.php b/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Map/Port.php
@@ -15,16 +15,6 @@
 
 class Port extends Map implements Matcher
 {
-    /**
-     * Constructor.
-     *
-     * @param array $siteAccessesConfiguration SiteAccesses configuration.
-     */
-    public function __construct( array $siteAccessesConfiguration )
-    {
-        parent::__construct( $siteAccessesConfiguration );
-    }
-
     public function getName()
     {
         return 'port';

diff --git a/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Map/URI.php b/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Map/URI.php
@@ -16,16 +16,6 @@
 
 class URI extends Map implements Matcher, URILexer
 {
-    /**
-     * Constructor.
-     *
-     * @param array $siteAccessesConfiguration SiteAccesses configuration.
-     */
-    public function __construct( array $siteAccessesConfiguration )
-    {
-        parent::__construct( $siteAccessesConfiguration );
-    }
-
     /**
      * Injects the request object to match against.
      *

diff --git a/eZ/Publish/Core/Persistence/InMemory/Tests/LanguageHandlerTest.php b/eZ/Publish/Core/Persistence/InMemory/Tests/LanguageHandlerTest.php
@@ -32,14 +32,6 @@ protected function setUp()
         $this->handler = $this->persistenceHandler->contentLanguageHandler();
     }
 
-    /**
-     * Removes stuff created in setUp().
-     */
-    protected function tearDown()
-    {
-        parent::tearDown();
-    }
-
     /**
      * Test load function
      *

diff --git a/eZ/Publish/Core/Persistence/InMemory/Tests/ObjectStateHandlerTest.php b/eZ/Publish/Core/Persistence/InMemory/Tests/ObjectStateHandlerTest.php
@@ -32,14 +32,6 @@ protected function setUp()
         $this->handler = $this->persistenceHandler->objectStateHandler();
     }
 
-    /**
-     * Removes stuff created in setUp().
-     */
-    protected function tearDown()
-    {
-        parent::tearDown();
-    }
-
     /**
      * @covers \eZ\Publish\Core\Persistence\InMemory\ObjectStateHandler::createGroup
      */

diff --git a/eZ/Publish/Core/REST/Client/Values/Content/ContentInfo.php b/eZ/Publish/Core/REST/Client/Values/Content/ContentInfo.php
@@ -48,9 +48,4 @@ public function __construct( ContentTypeService $contentTypeService, array $data
         parent::__construct( $data );
         $this->contentTypeService = $contentTypeService;
     }
-
-    public function __get( $property )
-    {
-        return parent::__get( $property );
-    }
 }
diff --git a/eZ/Publish/Core/REST/Server/Input/Parser/Criterion/ContentTypeId.php b/eZ/Publish/Core/REST/Server/Input/Parser/Criterion/ContentTypeId.php
@@ -11,7 +11,6 @@
 
 use eZ\Publish\Core\REST\Server\Input\Parser\Base;
 use eZ\Publish\Core\REST\Common\Input\ParsingDispatcher;
-use eZ\Publish\Core\REST\Common\UrlHandler;
 use eZ\Publish\Core\REST\Common\Exceptions;
 use eZ\Publish\API\Repository\Values\Content\Query\Criterion\ContentTypeId as ContentTypeIdCriterion;
 
@@ -20,11 +19,6 @@
  */
 class ContentTypeId extends Base
 {
-    public function __construct( UrlHandler $urlHandler )
-    {
-        parent::__construct( $urlHandler );
-    }
-
     /**
      * Parses input structure to a Criterion object
      *

diff --git a/eZ/Publish/Core/REST/Server/Input/Parser/ViewInput.php b/eZ/Publish/Core/REST/Server/Input/Parser/ViewInput.php
@@ -11,7 +11,6 @@
 
 use eZ\Publish\Core\REST\Server\Input\Parser\Criterion as CriterionParser;
 use eZ\Publish\Core\REST\Common\Input\ParsingDispatcher;
-use eZ\Publish\Core\REST\Common\UrlHandler;
 use eZ\Publish\Core\REST\Common\Exceptions;
 use eZ\Publish\API\Repository\Values\Content\Query;
 use eZ\Publish\Core\REST\Server\Values\RestViewInput;
@@ -22,16 +21,6 @@
  */
 class ViewInput extends CriterionParser
 {
-    /**
-     * Construct
-     *
-     * @param \eZ\Publish\Core\REST\Common\UrlHandler $urlHandler
-     */
-    public function __construct( UrlHandler $urlHandler )
-    {
-        parent::__construct( $urlHandler );
-    }
-
     /**
      * Parses input structure to a RestViewInput struct
      *