Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-23553: Checking for existence of legacy templates does not work #1062

Merged
merged 1 commit into from Oct 31, 2014
Merged

Fix EZP-23553: Checking for existence of legacy templates does not work #1062

merged 1 commit into from Oct 31, 2014

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Oct 31, 2014

JIRA issue: https://jira.ez.no/browse/EZP-23553

When trying to do something like this:

{% include [
        'NetgenSiteBundle:parts:' ~ template ~ '.html.twig',
        'design:parts/' ~ template ~ '.tpl',
        'design:parts/default.tpl'
    ] ignore missing
    with {
        'location': location,
        'node': location
    }
%}

And first two templates do not exist, but the third one does, nothing will be rendered, while the third template should be rendered.

What happens is that legacy rendering engine does not recognize a missing legacy template properly and instead returns an empty string to be rendered.

@lolautruche
Copy link
Contributor

Wow that's a good one 👍

+1
Review ping @andrerom @bdunogier @dpobel @pspanja @yannickroger

@bdunogier
Copy link
Member

Nice, +1.

lolautruche added a commit that referenced this pull request Oct 31, 2014
Fix EZP-23553: Checking for existence of legacy templates does not work
@lolautruche lolautruche merged commit 58e2a73 into ezsystems:master Oct 31, 2014
@emodric
Copy link
Contributor Author

emodric commented Oct 31, 2014

Wow, that was quick :)

Thanks guys! 👍

@lolautruche
Copy link
Contributor

Thanks @emodric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants