Fix EZP-22858: Display in HTML Comments name of the used template #1066
Conversation
To avoid display quirks with some (old) browsers 1. Start comment **after** DocType declaration 2. Stop comment **before** `</body>`
|
Review ping @flovntp @andrerom @bdunogier @dpobel @pspanja |
|
+1 |
|
Didn't we kind of say on the other PR that we don't need to do this as we don't care about layout issues in old browsers when in dev mode? Cause if we did, then I kind of prefer the simpler approach which does not have to mess with buffers (often cause of bugs when buffers are used on several levels for instance). |
|
Nope, you said:
😉 And I think this is safer this way, but I'm no browser expert... @dpobel ? |
|
In any case, if we apply the same method than WebProfiler (which is the case here), we need to use the buffer since content is directly echoed in compiled Twig templates. |
|
anything before the doctype puts IE9 (and below of course...) into the quirks mode which would break how the page is rendered and even if it's only in dev env., I think it's a good thing to try to avoid that :-) So +1 |
|
ok, thanks for chiming in @dpobel, then +1 |
|
Thanks, merging. |
This PR is an enhancement of #860.
It ensures that start/stop template comments are correctly displayed for layout templates, to avoid quirks with some (old) browsers.
</body>This only affects HTML templates