Fix EZP-23991: Refactor: FieldNameResolver should be shared by all search engines #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dude, you need to focus on merging, the tail of this train is longer than the remaining time of the sprint now! :) Review takes time! Maybe finish writing that blog post in between instead so we can catch up :) Also it is kind of tiring to spend time on reviewing temporary PR's and having to do it twice, so take max 2 at a time maybe (WIP). |
|
That was the last one ;) |
|
Closing in favour of #1186. |
pspanja
deleted the
fix-EZP-23991-refactor-search-extract-fieldnameresolver-tmp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves https://jira.ez.no/browse/EZP-23991, sub-task of https://jira.ez.no/browse/EZP-23940
The PR is based on #1175 and will be rebased on master when that is merged.
Common FieldNameResolver (renamed from FieldMap) is implemented and container is configured with field mappings for Elasticsearch and Solr Search Engines. Old FieldMap implementations are removed.