Fix EZP-23969: Refactor: Slots should be shared by all Search Engines #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @copyright Copyright (C) eZ Systems AS. All rights reserved. | ||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | ||
| * @version //autogentag// | ||
| */ | ||
|
|
||
| namespace eZ\Publish\Core\Search\Solr; | ||
| namespace eZ\Publish\Core\Search; |
There was a problem hiding this comment.
May I suggest we create a Common namespace or something?
If we do this we redo the mistake done in Persistence having several folders which are not implementation of a engine at root, messes up the convention of <API/SPI-part>/Implementation organization in Core.
There was a problem hiding this comment.
Yes, it makes sense. I'll update.
There was a problem hiding this comment.
Moved to Core\Search\Common in 3b5c3f3.
|
Now ready for review, ping @bdunogier, @lolautruche, @glye, @yannickroger. |
|
+1 |
1 similar comment
|
+1 |
|
Thanks! |
pspanja
added a commit
that referenced
this pull request
Feb 10, 2015
…-extract-slots Fix EZP-23969: Refactor: Slots should be shared by all Search Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves https://jira.ez.no/browse/EZP-23969, sub-task of https://jira.ez.no/browse/EZP-23940
This moves Slots into a common namespace and adapts the configuration, making them shared by all search engines (bar Legacy).