EZP-24672: Added ContentInfo to REST Location #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
There are unit tests on Value Object Visitors, they're gonna have to be updated. |
bdunogier
force-pushed
the
ezp24672-rest_location_contentinfo
branch
2 times, most recently
from
6e76d30
to
ec67954
Compare
andrerom
force-pushed
the
ezp24672-rest_location_contentinfo
branch
5 times, most recently
from
7f31ceb
to
c2c18d2
Compare
|
Updated tests, as far as I can see visited values are not generated in the unit tests, so testing of what is returned there is topic for functional tests, and currently there is none it seems (right @bdunogier ?) besides BDD. So review ping @pspanja |
andrerom
force-pushed
the
ezp24672-rest_location_contentinfo
branch
from
eda0a1b
to
4663807
Compare
|
@StephaneDiot , @mhyndle Any of you have any pointers on what changes are needed on UI to use this in TreeMenu? Basically this is intended to avoid having to call |
|
Looks good to me, +1 |
andrerom
added a commit
that referenced
this pull request
Aug 12, 2015
…tinfo EZP-24672: Added ContentInfo to REST Location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains a variable factoring in one file. The main change is that the RestLlocation also renders the ContentInfo object from the Location's properties.