Fix EZP-24854: http cache purge bans wrong/additional location ids

[joaoinacio]

JIRA: https://jira.ez.no/browse/EZP-24854

Problem

When issue http cache (varnish) purge requests, a regex is used with multiple location Ids.
The problem is that the regex is matching all locations that contain the value, for example, banning location 2 will also ban 12, 20, 21.

vcl ref: ban("obj.http.X-Location-Id ~ " + req.http.X-Location-Id);
https://github.com/ezsystems/ezplatform/blob/master/doc/varnish/vcl/varnish4.vcl#L116

Solution

Fix by making sure that location is one of the requested (starts/ends with provided value)

Tests

Manual

[andrerom]

+1 (also for 5.4 backport, but that goes w/o saying)

[glye]

Not sure, but since $locationIds is an array, don't we need to sort() here to guarantee the tests will always pass? If irrelevant, kindly disregard this, and +1 from me.

[lolautruche]

+1

[joaoinacio]

@glye : as it is currently the ids are expected in the same order, if they are sorted (in purge client) then they would need to be sorted as well in tests (and unsorted/random in the data provider) - so AFAICT there wouldn't be much gain?