EZP-19123: Make ezuser.login case in-sensitive across databases #1561

andrerom · 2016-01-20T21:25:06Z

https://jira.ez.no/browse/EZP-19123
Replaces #1527, needed for #1388 (addition-of/switch-to bcrypt user password hashing).

Todo:

upgrade script

bdunogier · 2016-01-25T10:04:52Z

Looks clean to me. Is the other approach better in some aspects ?

andrerom · 2016-01-25T10:11:23Z

Looks clean to me. Is the other approach better in some aspects ?

it was just easier, this one will need to deal with upgrade script. But this one is more correct, it makes all db's behave closer to how mysql did, which is what most people use.

bdunogier · 2016-01-25T19:36:57Z

If it is more correct then i'd rather go for it...

joaoinacio · 2016-01-26T11:06:25Z

eZ/Publish/API/Repository/UserService.php

@@ -148,8 +148,8 @@ public function loadAnonymousUser();
    /**
     * Loads a user for the given login and password.
     *
-     * This method is case sensitive in regards to $login and $password as a comparison of password hash is done
-     * which contains both parameters.
+     * Since 6.1 $login is handled case in-sensitive across all storage engines and database backends, however if login


Nitpick: I believe it's case insensitive (no hyphen)

andrerom · 2016-02-22T08:12:40Z

review ping @glye @joaoinacio

Note: Was previously attempting to normalize the characters, however did not find anything that does that for us easily and it's not within scope.

bdunogier · 2016-02-22T10:13:40Z

eZ/Publish/API/Repository/UserService.php

@@ -164,7 +164,8 @@ public function loadUserByCredentials($login, $password);
    /**
     * Loads a user for the given login.
     *
-     * Note: This method loads user by $login where $login might be case in-sensitive on certain storage engines!
+     * Since 6.1 $login is handled case insensitive across all storage engines and database backends, like was the case


Can be simplified to "login is case-insensitive".

bdunogier · 2016-02-22T10:15:56Z

Just a bit unsure about the "double wording": both "case insensitive" and "normalized" are used. Could we try to use only one of those ?

That aside, +1 on the implementation (but reviewed on mobile).

glye · 2016-02-22T11:56:51Z

+1, esp. after the ADD COLUMN was added :)

andrerom · 2016-02-22T13:11:28Z

data/update/postgres/unstable/dbupdate-6.1.0-to-6.2.0rc1.sql

@@ -0,0 +1,9 @@
+-- Set storage engine schema version number
+UPDATE ezsite_data SET value='6.1.0' WHERE name='ezpublish-version';


…g case in-sensitive index (#1682) * Revert unrelated parts of #1590 and #1561 * EZP-19123: Redo fix with lowercase index * EZP-19123: Lowercase login in loadByLogin() * EZP-25880: Add update sql scripts [skip ci]

andrerom force-pushed the user_login_normalized branch from 42650cd to cc5ca78 Compare January 21, 2016 12:33

andrerom changed the title ~~[WIP] User login normalized~~ [WIP] EZP-19123: Make ezuser.login case in-sensitive across databases Jan 21, 2016

andrerom mentioned this pull request Jan 26, 2016

[WIP][Integration] EZP-24744: Add test for user load case sensitivity #1527

Closed

joaoinacio reviewed Jan 26, 2016
View reviewed changes

andrerom force-pushed the user_login_normalized branch 2 times, most recently from 43ee5f3 to 3d0ac28 Compare January 27, 2016 17:43

andrerom force-pushed the user_login_normalized branch from 3d0ac28 to bca681f Compare February 21, 2016 21:52

andrerom changed the title ~~[WIP] EZP-19123: Make ezuser.login case in-sensitive across databases~~ EZP-19123: Make ezuser.login case in-sensitive across databases Feb 21, 2016

andrerom added 2 commits February 22, 2016 08:19

EZP-19123: Make ezuser.login case insensitive across databases

c984ed2

[TEST] Add integration test for login case insensitivity

ab33ef8

andrerom force-pushed the user_login_normalized branch from bca681f to 69609f4 Compare February 22, 2016 07:21

andrerom added 2 commits February 22, 2016 09:22

EZP-19123: Add upgrade sql for 6.2

a4850fd

[Travis] Set default_charset=UTF-8

166d044

andrerom force-pushed the user_login_normalized branch from 0e305f3 to 166d044 Compare February 22, 2016 08:22

bdunogier reviewed Feb 22, 2016
View reviewed changes

CS

8dbea99

andrerom reviewed Feb 22, 2016
View reviewed changes

[Update] Fix postgres update version number

06e88eb

andrerom merged commit 06e88eb into master Feb 22, 2016

andrerom deleted the user_login_normalized branch February 22, 2016 13:26

emodric mentioned this pull request Feb 23, 2016

EZP-19123: Make ezuser.login case in-sensitive across databases ezsystems/ezpublish-legacy#1239

Closed

emodric mentioned this pull request Apr 18, 2016

EZP-19123: Make ezuser.login case in-sensitive across databases netgen/ezpublish-legacy#1

Closed

andrerom mentioned this pull request Jun 14, 2016

EZP-19123: Missing SQL to copy ezuser.login to login_normalized #1590

Merged

andrerom added a commit that referenced this pull request Jun 14, 2016

Revert unrelated parts of #1590 and #1561

6d48e6f

andrerom mentioned this pull request Jun 15, 2016

EZP-25880: Make ezuser.login case in-sensitive across databases, using case in-sensitive index #1682

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EZP-19123: Make ezuser.login case in-sensitive across databases #1561

EZP-19123: Make ezuser.login case in-sensitive across databases #1561

andrerom commented Jan 20, 2016

bdunogier commented Jan 25, 2016

andrerom commented Jan 25, 2016

bdunogier commented Jan 25, 2016

joaoinacio Jan 26, 2016

andrerom commented Feb 22, 2016

bdunogier Feb 22, 2016

bdunogier commented Feb 22, 2016

glye commented Feb 22, 2016

andrerom Feb 22, 2016

		@@ -0,0 +1,9 @@
		-- Set storage engine schema version number
		UPDATE ezsite_data SET value='6.1.0' WHERE name='ezpublish-version';

EZP-19123: Make ezuser.login case in-sensitive across databases #1561

EZP-19123: Make ezuser.login case in-sensitive across databases #1561

Conversation

andrerom commented Jan 20, 2016

bdunogier commented Jan 25, 2016

andrerom commented Jan 25, 2016

bdunogier commented Jan 25, 2016

joaoinacio Jan 26, 2016

Choose a reason for hiding this comment

andrerom commented Feb 22, 2016

bdunogier Feb 22, 2016

Choose a reason for hiding this comment

bdunogier commented Feb 22, 2016

glye commented Feb 22, 2016

andrerom Feb 22, 2016

Choose a reason for hiding this comment