EZP-25453: improve root uri handling in Map\URI siteaccess matcher #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that siteaccess matching uses an URI map, When generating the URI to the root, I expect the URI to end without a slash
Avoids an offset error when parsing the root's URI with a siteaccess part.
|
+1, somewhat side: but I'm missing coverage for utf8 strings in the tests. Reason I mention this is that there is a incoming customer issue where we seem to have a utf8 encoding regression on 5.4.x because of 96f0e5b The issue also uncovers siteaccess matching does not support utf8 now, while it has at some point in the past. |
|
It's ok for me. Thanks @bdunogier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test + a fix for the mirror case (
/foo=>/).