Fix EZP-26164: error saving a binary field copied translation #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
approved these changes
Apr 13, 2017
yannickroger
approved these changes
Apr 13, 2017
andrerom
previously approved these changes
Apr 13, 2017
andrerom
dismissed
their stale review
Realize we should have test case for this
Well, yes. As for most things :) |
|
Sent to QA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Binary Field is saved with external data, but doesn't have a mimeType defined, gets it from the IOService using the stored file. Covers the case where a Field Value is copied from another translation and left untouched.