EZP-27666: Services should depend upon UrlRedecoratorInterface instead of UrlRedecorator #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of UrlRedecorator
alongosz
approved these changes
Jul 17, 2017
| @@ -22,10 +22,10 @@ class ImageConverter implements Converter | |||
| /** @var IOServiceInterface */ | |||
| private $imageIoService; | |||
|
|
|||
| /** @var UrlRedecorator */ | |||
| /** @var UrlRedecoratorInterface */ | |||
There was a problem hiding this comment.
We rather try to use FQCN in PhpDoc, so this is another thing that we missed initially. While at this, could you also change the above IOServiceInterface for the consistency's sake?
… instead of UrlRedecorator
alongosz
approved these changes
Jul 17, 2017
andrerom
approved these changes
Jul 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR change a type hints from
eZ\Publish\Core\IO\UrlRedecoratorintoeZ\Publish\Core\IO\UrlRedecoratorInterfacein the following services:eZ\Publish\Core\Persistence\Legacy\Content\FieldValue\Converter\ImageConvertereZ\Publish\Core\FieldType\Image\ImageStorage\Gateway\DoctrineStorageeZ\Publish\Core\FieldType\Image\ImageStorage\Gateway\LegacyStorage