EZP-28118: Error in RelationConverter on content after editing class in legacy #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on field definition in legacy
andrerom
changed the title
alongosz
requested changes
Oct 24, 2017
| if ( | ||
| ($selectionType = $dom->getElementsByTagName('selection_type')) && | ||
| $selectionType->item(0)->hasAttribute('value') | ||
| ) { | ||
| $fieldSettings['selectionMethod'] = (int)$selectionType->item(0)->getAttribute('value'); |
There was a problem hiding this comment.
Quick test showed me that getElementsByTagName never returns an empty value. It's always \DOMNodeList. It has property length. If length = 0, then $selectionType->item(0) will return null and calling hasAttribute will throw an exception.
So rather:
if (($selectionTypeFirstItem = $dom->getElementsByTagName('selection_type')->item(0)) && $selectionTypeFirstItem->hasAttribute('value'))
There was a problem hiding this comment.
Ok, so DomList never evaluates to empty here?
There was a problem hiding this comment.
Yes. Consider the following example (just re-pasting from elsewhere to keep discussion here consistent):
$xml = <<< XML
<?xml version="1.0" encoding="utf-8"?>
<para></para>
XML;
$dom = new DOMDocument;
$dom->loadXML($xml);
if (($elements = $dom->getElementsByTagName('non_existent_tag'))) {
var_dump($elements->item(0));
}will output NULL.
| if ( | ||
| ($selectionType = $dom->getElementsByTagName('selection_type')) && | ||
| $selectionType->item(0)->hasAttribute('value') | ||
| ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: