Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-28470: Allow state limitation on manage_locations #2182

Merged
merged 1 commit into from Dec 12, 2017
Merged

EZP-28470: Allow state limitation on manage_locations #2182

merged 1 commit into from Dec 12, 2017

Conversation

wizhippo
Copy link
Contributor

@wizhippo wizhippo commented Dec 10, 2017 •
edited

@andrerom
Copy link
Contributor

andrerom commented Dec 11, 2017 •
edited

@wizhippo Issue does not explain this PR, does legacy allow this?

@wizhippo
Copy link
Contributor Author

@andrerom I have corrected the jira link. Yes legacy allows you to set state limitations on remove https://github.com/ezsystems/ezpublish-legacy/blob/f02208e873a9d7d20293a64d1fdaa9ba2c5b79ee/kernel/content/module.php#L680

@andrerom
Copy link
Contributor

But this is manage_locations

@wizhippo
Copy link
Contributor Author

Again you are correct. Sorry manage locations is a bit confusing as it also applies to trashing and item. So then no this was not in legacy, but this is needed as described to disallow trashing items based on state.

@wizhippo
Copy link
Contributor Author

To add in my use case I also do not want the user to be able to move the item to another location either.

@andrerom
Copy link
Contributor

Ok, then maybe open PR on this for legacy too so we don't end up in any issues for legacy bridge users.

@andrerom
Copy link
Contributor

@wizhippo can you change target branch to 6.13?

andrerom
andrerom approved these changes Dec 11, 2017
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with ezsystems/ezpublish-legacy#1335 and on 6.13 branch

@wizhippo wizhippo changed the base branch from master to 6.13 December 11, 2017 15:42
@andrerom andrerom merged commit 8e6bbbc into ezsystems:6.13 Dec 12, 2017
@wizhippo wizhippo deleted the patch-1 branch June 26, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@wizhippo @andrerom