Fix storing external data for Legacy storage engine #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal storage data
…ing external data
| { | ||
| $fieldsToCopy[$fieldDefinition->id][$languageCode] = | ||
| $contentFieldMap[$fieldDefinition->id][$content->versionInfo->contentInfo->mainLanguageCode]; | ||
| $createInNewLanguageCode = $languageCode; |
There was a problem hiding this comment.
Hmmm, what is $createInNewLanguageCode supposed to be for exactly ? I can see it used in the next foreach block, but I'm still a bit confused.
There was a problem hiding this comment.
This is used on the same level, when calling createExistingFieldInNewVersion(). Used for creating non-translatable field in non-main language, from the field in main language.
There was a problem hiding this comment.
Haaan I had not seen the two foreaches merged into ones. My bad :-)
9 tasks
|
+1, @bdunogier your ok with this? |
|
Yes, I am. It really needs to go in, maintaining my own PR is becoming a nightmare. |
andrerom
added a commit
that referenced
this pull request
Mar 4, 2013
Fix storing external data for Legacy storage engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes storing external data for Legacy storage engine.
Some field type require that external data is copied in all cases.
This was not done when creating existing fields in new version, where data was copied only for non-translatable fields in non-main language.