EZP-29279: Fix value displayed by the Date Field Type being affected by server time zone #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by server time zone
andrerom
approved these changes
Aug 17, 2018
alongosz
approved these changes
Aug 20, 2018
|
adding to @alongosz's question, shouldn't we do the same for ezdatetime block in the same field? |
|
It probably also affects other Field Types, although I started with Date Field Type to make it display correctly in all versions of eZ (other related PRs: ezsystems/PlatformUIBundle#984, ezsystems/ezplatform-admin-ui#598, ezsystems/ezpublish-legacy#1384). Next step would be to do the same for other Field Types (Time and Datetime). |
|
👍 |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.7Currently, the value for Date Field Type displayed in the front office is affected by the server's timezone, meaning that if the server has timezone below (west of) UTC, then the previous day is displayed.
The value stored in the database is always midnight in UTC.
Twig by default applies the server's timezone when using its
localizeddatemethod, so in this PR I fix the issue by making sure it doesn't.The minor BC break that I mentioned is that someone could rely on the wrong behavior (but they really shouldn't).
TODO:
$ composer fix-cs).