Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29619: StashPass should check if config[caches] is set #2450

Merged
merged 1 commit into from Sep 19, 2018
Merged

EZP-29619: StashPass should check if config[caches] is set #2450

merged 1 commit into from Sep 19, 2018

Conversation

kmadejski
Copy link
Member

@kmadejski kmadejski commented Sep 18, 2018 •
edited

Question Answer
JIRA issue EZP-29619
Bug yes
New feature no
Target version 6.7/6.13 (5.4: https://github.com/ezsystems/ezpublish-kernel-ee/pull/186)
BC breaks no
Tests pass yes
Doc needed no

As mentioned in the JIRA ticket, there should be an additional check if the Stash configuration even exists.

TODO:

  • Implement feature / fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@kmadejski kmadejski self-assigned this Sep 18, 2018
@andrerom
Copy link
Contributor

@kmadejski Which releases are affected?

@andrerom andrerom merged commit 806d52d into ezsystems:6.7 Sep 19, 2018
@kmadejski
Copy link
Member Author

@andrerom 6.13.4 & 6.7.8

@andrerom
Copy link
Contributor

5.4.12?

@kmadejski
Copy link
Member Author

@andrerom yes, 5.4.12 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@andrerom andrerom andrerom approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@kmadejski kmadejski

Labels
Ready for review
Milestone
No milestone
4 participants
@kmadejski @andrerom @adamwojs @alongosz