EZP-30822: Fixed wrong usage of hasAccess in URLAliasService #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
force-pushed
the
EZP-30822
branch
2 times, most recently
from
e86b763
to
7683510
Compare
adamwojs
reviewed
Aug 9, 2019
alongosz
requested changes
Aug 9, 2019
eZ/Publish/API/Repository/Tests/URLAliasServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Aug 9, 2019
adamwojs
approved these changes
Aug 9, 2019
micszo
approved these changes
Aug 9, 2019
|
You can merge it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5Fix wrong usage of hasAccess() in repository in favor of canUser(). This is needed to solve an issue when there is a Role Assignment Limitation. In this case, they will return info to permission system they abstain from "voting" and return an array of Limitations.
TODO:
$ composer fix-cs).