Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-20518: Default layout for legacy content fallback configurable by SA #277

Closed
wants to merge 3 commits into from

Conversation

dpobel
Copy link
Contributor

@dpobel dpobel commented Mar 28, 2013

Jira issue: https://jira.ez.no/browse/EZP-20518

Description

This patch adds the ability to define by siteaccess the pagelayout to use while rendering the content in the legacy

See also ezsystems/ezpublish-community#44

Test

manual tests

@@ -1,3 +1,6 @@
parameters:
# Override this with a Twig template definition to have Twig render legacy pagelayouts
ezpublish_legacy.view.legacy_layout: ~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make that ezpublish_legacy.view.legacy_layout is configurable by siteaccess ?
Ping @joekepley

@lolautruche
Copy link
Contributor

Apart my request, +1

@dpobel
Copy link
Contributor Author

dpobel commented Mar 28, 2013

Added the same system for the pagelayout used for "non content pages" as requested by @lolautruche

@lolautruche
Copy link
Contributor

+1

@@ -1,3 +1,7 @@
parameters:
# Override this with a Twig template definition to have Twig render legacy pagelayouts
ezpublish_legacy.view.legacy_layout: ~
# for modules. If left null, the pagelayout from legacy is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be clearer to say "layout override for legacy modules". "for modules" might not be enough of a clue that it's for legacy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (and don't forget to uppercase the first letter :-P)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved the comment in 7f37be4

@lolautruche
Copy link
Contributor

+1

@dpobel
Copy link
Contributor Author

dpobel commented Mar 29, 2013

Manually merged in c5b1413

@dpobel dpobel closed this Mar 29, 2013
@dpobel dpobel deleted the ezp-20518_legacy_layout_sa branch March 29, 2013 10:07
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5ce2a1c on ezp-20518_legacy_layout_sa into * on master*.

@andrerom
Copy link
Contributor

I can not see any hooks current enabled fro coveralls, @bdunogier could you nuke (disable) our account there until we actually use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants