New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZP-20518: Default layout for legacy content fallback configurable by SA #277
Conversation
@@ -1,3 +1,6 @@ | |||
parameters: | |||
# Override this with a Twig template definition to have Twig render legacy pagelayouts | |||
ezpublish_legacy.view.legacy_layout: ~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make that ezpublish_legacy.view.legacy_layout
is configurable by siteaccess ?
Ping @joekepley
Apart my request, +1 |
Added the same system for the pagelayout used for "non content pages" as requested by @lolautruche |
+1 |
@@ -1,3 +1,7 @@ | |||
parameters: | |||
# Override this with a Twig template definition to have Twig render legacy pagelayouts | |||
ezpublish_legacy.view.legacy_layout: ~ | |||
# for modules. If left null, the pagelayout from legacy is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be clearer to say "layout override for legacy modules". "for modules" might not be enough of a clue that it's for legacy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (and don't forget to uppercase the first letter :-P)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved the comment in 7f37be4
+1 |
Manually merged in c5b1413 |
Changes Unknown when pulling 5ce2a1c on ezp-20518_legacy_layout_sa into * on master*. |
I can not see any hooks current enabled fro coveralls, @bdunogier could you nuke (disable) our account there until we actually use it? |
Jira issue: https://jira.ez.no/browse/EZP-20518
Description
This patch adds the ability to define by siteaccess the pagelayout to use while rendering the content in the legacy
See also ezsystems/ezpublish-community#44
Test
manual tests