Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-20518: Default layout for legacy content fallback configurable by SA #277

Closed
wants to merge 3 commits into from

Conversation

@dpobel
Copy link
Contributor

dpobel commented Mar 28, 2013

Jira issue: https://jira.ez.no/browse/EZP-20518

Description

This patch adds the ability to define by siteaccess the pagelayout to use while rendering the content in the legacy

See also ezsystems/ezpublish-community#44

Test

manual tests

@lolautruche
lolautruche reviewed Mar 28, 2013
View changes
eZ/Bundle/EzPublishLegacyBundle/Resources/config/default_settings.yml Outdated
@@ -1,3 +1,6 @@
parameters:
# Override this with a Twig template definition to have Twig render legacy pagelayouts
ezpublish_legacy.view.legacy_layout: ~

This comment has been minimized.

Copy link
@lolautruche

lolautruche Mar 28, 2013

Contributor

Can you please make that ezpublish_legacy.view.legacy_layout is configurable by siteaccess ?
Ping @joekepley

@lolautruche

This comment has been minimized.

Copy link
Contributor

lolautruche commented Mar 28, 2013

Apart my request, +1

@dpobel

This comment has been minimized.

Copy link
Contributor Author

dpobel commented Mar 28, 2013

Added the same system for the pagelayout used for "non content pages" as requested by @lolautruche

@lolautruche

This comment has been minimized.

Copy link
Contributor

lolautruche commented Mar 28, 2013

+1

@@ -1,3 +1,7 @@
parameters:
# Override this with a Twig template definition to have Twig render legacy pagelayouts
ezpublish_legacy.view.legacy_layout: ~
# for modules. If left null, the pagelayout from legacy is used.

This comment has been minimized.

Copy link
@joekepley

joekepley Mar 28, 2013

Contributor

Might be clearer to say "layout override for legacy modules". "for modules" might not be enough of a clue that it's for legacy.

This comment has been minimized.

Copy link
@lolautruche

lolautruche Mar 28, 2013

Contributor

+1 (and don't forget to uppercase the first letter :-P)

This comment has been minimized.

Copy link
@dpobel

dpobel Mar 29, 2013

Author Contributor

Improved the comment in 7f37be4

@@ -0,0 +1,14 @@

This comment has been minimized.

Copy link
@joekepley

joekepley Mar 28, 2013

Contributor

I'm guessing this file is added to serve as an example since the default setting is null. Good idea! It might benefit from a descriptive comment on its purpose.

This comment has been minimized.

Copy link
@lolautruche

lolautruche Mar 28, 2013

Contributor

+1 on this. And more than a comment, a big <h1> telling that you're using the default layout with a hint on how to override it would be nice 😃

This comment has been minimized.

Copy link
@dpobel

dpobel Mar 29, 2013

Author Contributor

Implemented in 5ce2a1c
@joekepley actually, this template is the default one for content handled by the legacy.

@lolautruche

This comment has been minimized.

Copy link
Contributor

lolautruche commented Mar 29, 2013

+1

@dpobel

This comment has been minimized.

Copy link
Contributor Author

dpobel commented Mar 29, 2013

Manually merged in c5b1413

@dpobel dpobel closed this Mar 29, 2013
@dpobel dpobel deleted the ezp-20518_legacy_layout_sa branch Mar 29, 2013
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 5, 2014

Coverage Status

Changes Unknown when pulling 5ce2a1c on ezp-20518_legacy_layout_sa into * on master*.

@andrerom

This comment has been minimized.

Copy link
Member

andrerom commented Jun 10, 2014

I can not see any hooks current enabled fro coveralls, @bdunogier could you nuke (disable) our account there until we actually use it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.