New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31558: Updated loadByIdentifier to use escapeForCacheKey function before get value from cache #3018
Conversation
… before get value from cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to verify, whether escaping is necessary in some other methods, e.g. loadGroupByIdentifier
and handlers (if needed).
I will check and if necessary I make changes, for now, I change to WIP |
@mateuszdebinski You may go ahead an add this everywhere where we load by identifier or remote id I think, if you are up for it, bette be safe then sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After internal sync, it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA approved on eZPlatform 2.5.9 with diff.
You can merge it up to ezplatform-kernel/1.0 and master |
7.5
/master
TODO:
$ composer fix-cs
).