Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-27324: Proper media/binary uri is now shown & generated for old content versions #3033

Merged
merged 1 commit into from May 20, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented May 12, 2020

Question Answer
JIRA issue EZP-27324
Bug/Improvement yes
New feature no
Target version 7.5
BC breaks no
Tests pass no
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@micszo micszo self-assigned this May 13, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On eZ Platform EE 2.5 there is a regression when creating a draft from the latest version.

Steps:
0. Start with a clean session after applying the changes.

  1. Create a CT with ezmedia and ezbinaryfile fields.
  2. Create a CI using that CT.
  3. Upload a valid video and e.g. pdf file.
  4. Publish.
  5. Enter edit mode.
  6. Examine media and file fields.

Actual result: On the media field there's a constant spinner. On the file field when trying to preview a redirect to login happens.

EZP-27324

@lserwatka
Copy link
Member

@micszo Let's merge this one, and fill a new ticket. @ViniTou will have a look. This PR is blocking work in 3.1.

@micszo
Copy link
Member

micszo commented May 19, 2020

@lserwatka ok 😄 🙈
I will create a ticket shortly.

@micszo
Copy link
Member

micszo commented May 19, 2020

Ticket for the above issue: https://jira.ez.no/browse/EZP-31639.

@micszo micszo removed their assignment May 19, 2020
@ViniTou ViniTou merged commit 467f915 into 7.5 May 20, 2020
@ViniTou ViniTou deleted the EZP-27324-respect-media-version branch February 23, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants