EZP-31644: Fixed serialization of Compound SiteAccess matcher #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
force-pushed
the
EZP-31644
branch
2 times, most recently
from
a1379a0
to
2e0a1ef
Compare
alongosz
approved these changes
May 21, 2020
konradoboza
approved these changes
May 21, 2020
glye
approved these changes
May 21, 2020
mikadamczyk
force-pushed
the
EZP-31644
branch
3 times, most recently
from
e03ceac
to
94e6664
Compare
adamwojs
approved these changes
May 22, 2020
EZP-31644: [CR] Fixed serialization of Compound SiteAccess matcher
micszo
approved these changes
May 25, 2020
There was a problem hiding this comment.
Checked the list of matchers for the two regressions and new issues and didn't find exceptions now.
Tested on 1.13.5 with diff, on 2.5 with branch and on 3.0 with branch. 5.4 will be tested with another PR.
Patch for 2.5 wasn't available.
blankse
pushed a commit
to datafactory/ezpublish-kernel
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.13During the serialization of the compound matcher the whole container was serialized which is unnecessary (see: https://github.com/ezsystems/ezpublish-kernel/blob/7.5/eZ/Publish/Core/MVC/Symfony/SiteAccess/Matcher/Compound.php#L127)
Also, Symfony serializer does not serialize correctly nested sub-matchers during serialization of matcher (when compound matcher is used)
TODO:
$ composer fix-cs).