Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ContentExtension] Fix missing return statement under getContentType #3072

Closed
wants to merge 1 commit into from
Closed

[ContentExtension] Fix missing return statement under getContentType #3072

wants to merge 1 commit into from

Conversation

ahmed-bhs
Copy link
Contributor

No description provided.

@andrerom
Copy link
Contributor

This does not make much sense, PHP will always return null if no explicit return is done.

@ahmed-bhs ahmed-bhs closed this Oct 23, 2020
@ahmed-bhs
Copy link
Contributor Author

@andrerom yes I know, it's just a good practice to return null when the function explicitly returns null values.

@andrerom
Copy link
Contributor

True, for readability it has some value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@ahmed-bhs @andrerom