Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32401: Fixed handling trashed Content by LocationLimitation #3093

Merged
merged 2 commits into from
Mar 29, 2021
Merged

EZP-32401: Fixed handling trashed Content by LocationLimitation #3093

merged 2 commits into from
Mar 29, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Mar 25, 2021 •
edited
Loading

Question Answer
JIRA issue EZP-32401
Bug yes
New feature no
Target version 7.5
BC breaks no
Tests pass yes
Doc needed no

When Content was trashed and it had reverse relation the Location was not accessible. Therefore additional condition had to be added which exports trashed Location and uses it as a target.

TODO:

  • Fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 added the Bug label Mar 25, 2021
@barw4 barw4 self-assigned this Mar 25, 2021
@barw4 barw4 requested a review from a team March 25, 2021 10:54
alongosz
alongosz requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use case should be easily reproducible via integration test.

Besides commit message and PR title can be formed better (plural here is not "contents"). How about "Fixed handling trashed Content by LocationLimitation"?

@barw4 barw4 changed the title EZP-32401: Added trashed Contents support to LocationLimitation EZP-32401: Fixed handling trashed Content by LocationLimitation Mar 25, 2021
@barw4
Copy link
Member Author

barw4 commented Mar 25, 2021

@alongosz integration test added in 54513ac

@barw4 barw4 requested a review from alongosz March 25, 2021 13:58
@tomaszszopinski tomaszszopinski self-assigned this Mar 29, 2021
tomaszszopinski
tomaszszopinski approved these changes Mar 29, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5 & v2.5.17 with patch & diff.

@lserwatka lserwatka merged commit a18ac4c into 7.5 Mar 29, 2021
@lserwatka lserwatka deleted the ezp-32401-fix-location-limitation-trashed-content branch March 29, 2021 13:32
@lserwatka
Copy link
Member

Could you merge it up?

@barw4
Copy link
Member Author

barw4 commented Mar 29, 2021

Holding on with merge until #3092 is merged.

@alongosz alongosz mentioned this pull request Apr 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianz5 damianz5 damianz5 approved these changes

@alongosz alongosz alongosz approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
5 participants
@barw4 @lserwatka @damianz5 @alongosz @tomaszszopinski