Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-947: Modified deleteVersion API method to remove content if necessary #3118

Merged
merged 3 commits into from
Sep 9, 2021
Merged

IBX-947: Modified deleteVersion API method to remove content if necessary #3118

merged 3 commits into from
Sep 9, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Sep 7, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-947
Type bug
Target eZ Platform version v2.5
BC breaks no

As the title states.

Related repository-forms PR: ezsystems/repository-forms#349.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@barw4 barw4 self-assigned this Sep 7, 2021
@barw4 barw4 requested review from alongosz and a team September 7, 2021 15:05
@barw4 barw4 mentioned this pull request Sep 7, 2021
Closed
6 tasks
@alongosz alongosz requested review from Steveb-p, adamwojs and a team September 7, 2021 15:06
@barw4 barw4 mentioned this pull request Sep 7, 2021
Merged
2 tasks
@tomaszszopinski tomaszszopinski self-assigned this Sep 9, 2021
tomaszszopinski
tomaszszopinski approved these changes Sep 9, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5 with diff.

@alongosz alongosz merged commit 0b694bd into 7.5 Sep 9, 2021
@alongosz alongosz deleted the ibx-947-refactor-delete-version branch September 9, 2021 23:45
@alongosz
Copy link
Member

alongosz commented Sep 9, 2021

@barw4 please hold with merge up, you'll get a lot of conflicts from #3114. Working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved
Milestone
No milestone
6 participants
@barw4 @alongosz @mikadamczyk @Steveb-p @Nattfarinn @tomaszszopinski